Calls array and intrinsic stub routines in shenandoahSupport.cpp

Kennke, Roman rkennke at amazon.de
Tue Feb 28 11:38:53 UTC 2023


Hello Jamil,

Sorry for the very late reply. The email got stuck in the moderator 
queue and I only noticed it now.


> Volodymyr and I have implemented some new intrinsics for JDK 20 (see
> OpenJDK PRs https://github.com/openjdk/jdk/pull/7702 and
> https://github.com/openjdk/jdk/pull/10582).  Volodymyr recently came
> across the calls[] array in shenandoahSupport.cpp and was wondering
> whether our new intrinsics need to be added to this array and what the
> impact of having there there or not is.

This array, or rather the routine that uses it, is for barrier 
verification in Shenandoah. It checks that intrinsics that require 
barriers do have the right barriers applied. We should perhaps check if 
this list is still current and if any work is needed. I would not expect 
any code to fail because of this, unless when using 
+ShenandoahVerifyOptoBarriers.

Thanks for raising this!

Cheers,
Roman



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879




More information about the shenandoah-dev mailing list