RFR: 8299312: Clean up BarrierSetNMethod
Martin Doerr
mdoerr at openjdk.org
Tue Jan 3 15:58:49 UTC 2023
On Fri, 23 Dec 2022 12:00:46 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:
> The terminology in BarrierSetNMethod is not crisp. In platform code we talk about a per-nmethod "guard value", but on shared level we call the same value arm value or disarm value in different contexts. But it really depends on the value whether the nmethod is disarmed or armed. We should embrace the "guard value" terminology and lift it in to the shared code level.
> We also have more functionality than we need on platform level. The platform level only needs to know how to deoptimize, and how to set/get the guard value of an nmethod. The more specific functionality should be moved to the shared code and be expressed in terms of said setter/getter.
With https://github.com/openjdk/jdk/commit/245f0cf4ac9dc655bfe2abb1c88c6ed1ddffd291, nmethod entry barriers are implemented on all platforms, now. The ARM32 parts should be added. (Also see failing pre-submit test.)
-------------
PR: https://git.openjdk.org/jdk/pull/11774
More information about the shenandoah-dev
mailing list