RFR: Allow heuristic trigger to increase capacity instead of running a collection

Y. Srinivas Ramakrishna ysr at openjdk.org
Wed Jan 4 16:59:20 UTC 2023


On Fri, 30 Dec 2022 00:07:29 GMT, William Kemper <wkemper at openjdk.org> wrote:

> Before the adaptive heuristic starts a collection, it will attempt to increase the capacity of its generation. If the capacity is increased, the heuristic will re-evaluate the trigger criteria.
> 
> There is also a change here to attempt to increase the size of the old generation in response to a promotion failure.

The changes look ok.

I did wonder though if one might (for odd situations) reduce the number of recursions through `should_start_gc()` by having some notion of error that we are trying to correct when we call `resize_and_and_evaluate(/* pass in error or size differential here */)` from `should_start_gc()`. Anyway, just a thought for you to think about.

Reviewed!

-------------

Marked as reviewed by ysr (Author).

PR: https://git.openjdk.org/shenandoah/pull/190


More information about the shenandoah-dev mailing list