RFR: Fix allocate aligned [v3]

Kelvin Nilsen kdnilsen at openjdk.org
Thu Jan 5 01:41:49 UTC 2023


On Thu, 5 Jan 2023 01:10:08 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove redundant test for result != nullptr
>
> src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp line 66:
> 
>> 64:     // We don't need to register the PLAB.  Its content will be registered as objects are allocated within it and/or
>> 65:     // when the PLAB is retired.
>> 66:     ShenandoahHeap::heap()->card_scan()->register_object(obj);
> 
> In reviewing my own code, it looks like my implementation contradicts the comment.  I'm going to retest without line 66.

Making this change and testing on regression suite pipeline before integration.

-------------

PR: https://git.openjdk.org/shenandoah/pull/192


More information about the shenandoah-dev mailing list