Integrated: Fix allocate aligned
Kelvin Nilsen
kdnilsen at openjdk.org
Thu Jan 5 17:04:28 UTC 2023
On Thu, 5 Jan 2023 00:55:14 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
> An error was discovered in the implementation and use of allocate_aligned(), which is used to allocate PLABs that align with remembered set card boundaries. In the previous implementation, if the required alignment padding was smaller than the minimum filler object, the additional card's memory worth of padding might cause the PLAB to span beyond the end of the selected heap region. This PR addresses the error. This code successfully runs our internal pipeline of tests without any regressions.
>
> In the current context, this code is not fully exercised due to very limited allocation of PLABs within heap regions that already hold previously allocated PLABs. This code has also been exercised in the context of code that more aggressively packs multiple PLABs into heap regions. That additional code will be integrated with a future PR.
This pull request has now been integrated.
Changeset: 7e9a1d49
Author: Kelvin Nilsen <kdnilsen at openjdk.org>
URL: https://git.openjdk.org/shenandoah/commit/7e9a1d49eae7bff80e2b678f2402a4ecdf6c748f
Stats: 63 lines in 4 files changed: 43 ins; 7 del; 13 mod
Fix allocate aligned
Reviewed-by: wkemper, ysr
-------------
PR: https://git.openjdk.org/shenandoah/pull/192
More information about the shenandoah-dev
mailing list