RFR: 8299312: Clean up BarrierSetNMethod [v2]

[Erik Österlund]

On Sat, 7 Jan 2023 10:08:36 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Erik Österlund has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - ARM support
>>  - Merge branch 'master' into 8299312_barrier_set_nmethod_cleanup
>>  - Fix Shenandoah build
>>  - 8299312: Clean up BarrierSetNMethod
>
> Looks good to me.

Thanks for the review @RealFYang!

> src/hotspot/share/runtime/thread.hpp line 118:
> 
>> 116:   // On AArch64, the high order 32 bits are used by a "patching epoch" number
>> 117:   // which reflects if this thread has executed the required fences, after
>> 118:   // an nmethod gets disarmed. The low order 32 bit denote the disarmed value.
> 
> Nit:
> I think this should be:
> "The low order 32 bits denote the disarmed value."
> instead of:
> "The low order 32 bit denote the disarmed value."

Yes, you are right, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/11774