RFR: 8299673: Simplify object pinning interactions with string deduplication

[Stefan Karlsson]

On Tue, 10 Jan 2023 10:04:48 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

> When raw char* String contents are exposed to JNI code, we 
> 
> 1. Load the string.value and pin it 
> 2. Run native code 
> 3. Load the string.value and unpin it 
> 
> Given this sequence we would be in trouble if between 1 and 3, string deduplication changed the value object. Then the pinning and unpinning wouldn't be balanced. 
> 
> The current approach for dealing with this is to have a bunch of code to guard against deduplication. An alternative simpler solution is to just change step 3 to pass in the same value. We already have enough information available to do that. Then the pinning and unpinning is also balanced, and we don't need to have any special interactions with string deduplication and can decouple these orthogonal concerns.
> 
> It's worth noting though that the contract of pin_object now makes it explicit that pinned objects must not be recycled, even if not otherwise reachable. That seems to come naturally for region based pinning, but is worth keeping in mind. The exposed char* might be the only thing referencing the string value when string dedup happens concurrently.

Marked as reviewed by stefank (Reviewer).

src/hotspot/share/gc/z/zCollectedHeap.cpp line 27:

> 25: #include "classfile/classLoaderData.hpp"
> 26: #include "gc/shared/gcLocker.inline.hpp"
> 27: #include "gc/shared/gcHeapSummary.hpp"

Sort order

-------------

PR: https://git.openjdk.org/jdk/pull/11923