RFR: Broaden plab region search [v2]
Kelvin Nilsen
kdnilsen at openjdk.org
Thu Jan 12 21:39:38 UTC 2023
On Wed, 11 Jan 2023 16:43:31 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Unify GC heap status logging
>
> src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp line 179:
>
>> 177: size_t old_available = heap->old_generation()->available();
>> 178: size_t young_available = heap->young_generation()->available();
>> 179: log_info(gc, ergo)("At end of Full GC, old_available: " SIZE_FORMAT "%s out of total: " SIZE_FORMAT "%s,"
>
> Consider `ShenandoahGeneration::log_status`.
I've integrated the two heap-status logging approaches. Let me know what you think... Thanks for suggestion.
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 3194:
>
>> 3192: } else {
>> 3193: // This object is not live so we don't verify dirty cards contained therein
>> 3194: assert(tams != nullptr, "If object is not live, ctx and tams should be non-null");
>
> Might need to rebase these changes after integrating #197 .
So far, git seems to feel like there are "no conflicts". This code is identical to what I delivered in PR197.
-------------
PR: https://git.openjdk.org/shenandoah/pull/198
More information about the shenandoah-dev
mailing list