RFR: 8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc
Roman Kennke
rkennke at openjdk.org
Mon Jan 16 09:26:10 UTC 2023
On Thu, 12 Jan 2023 16:15:08 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> $ CONF=linux-x86_64-server-fastdebug make test TEST=jdk/internal/vm/Continuation/BasicExt.java TEST_VM_OPTS="-XX:+UseShenandoahGC"
>
> # Internal Error (/home/shade/trunks/jdk/src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp:479), pid=406430, tid=406562
> # assert(GCCause::is_user_requested_gc(cause) || GCCause::is_serviceability_requested_gc(cause) || cause == GCCause::_metadata_GC_clear_soft_refs || cause == GCCause::_codecache_GC_aggressive || cause == GCCause::_codecache_GC_threshold || cause == GCCause::_full_gc_alot || cause == GCCause::_wb_full_gc || cause == GCCause::_wb_breakpoint || cause == GCCause::_scavenge_alot) failed: only requested GCs here: WhiteBox Initiated Young GC
> #
> ```
>
> Added a missing cause into the assert. The test starts to pass.
Looks good to me, thank you!
-------------
Marked as reviewed by rkennke (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11970
More information about the shenandoah-dev
mailing list