RFR: 8299673: Simplify object pinning interactions with string deduplication [v2]

Erik Österlund eosterlund at openjdk.org
Tue Jan 17 07:58:12 UTC 2023


On Tue, 17 Jan 2023 02:02:47 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Erik Österlund has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Include sorting order
>>  - Merge branch 'master' into 8299673_pin_dedup
>>  - More Kim feedback
>>  - Feedback from Kim
>>  - 8299673: Simplify object pinning interactions with string deduplication
>
> Initially I was a bit unsure about the conceptual model here, as I was thinking that pinning is a very general concept, where in fact it only relates to these JNI "critical" functions. So in that sense every GC must support pinning as required by those functions, so this simplification looks very neat. Thanks.

Thanks for the review, @dholmes-ora!

-------------

PR: https://git.openjdk.org/jdk/pull/11923


More information about the shenandoah-dev mailing list