RFR: 8300644: Remove gc/shenandoah/jni/TestStringCriticalWithDedup.java

Matthias Baesken mbaesken at openjdk.org
Tue Jan 24 09:06:03 UTC 2023


On Thu, 19 Jan 2023 10:26:38 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

> The gc/shenandoah/jni/TestStringCriticalWithDedup.java test was designed to catch failure to pin strings being passed out to JNI critical users, because that used to be dangerous. After [JDK-8299673](https://bugs.openjdk.org/browse/JDK-8299673) that is not dangerous any longer. Conversely, now we kind of want deduplication to proceed regardless of JNI critical, which defeats the purpose of this test. It should be removed.

LGTM

-------------

Marked as reviewed by mbaesken (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12089


More information about the shenandoah-dev mailing list