RFR: JDK-8301225: Replace NULL with nullptr in share/gc/shenandoah/

[Kelvin Nilsen]

On Fri, 27 Jan 2023 10:19:33 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/gc/shenandoah/. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
> 
> Thanks!

Looks good to me.  Thanks for doing this.

A few comments about copyright notices.

Marked as reviewed by kdnilsen (no project role).

src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 2:

> 1: /*
> 2:  * Copyright (c) 2023, 2023, Oracle and/or its affiliates. All rights reserved.

minor glitch here

src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2023, 2023, Oracle and/or its affiliates. All rights reserved.

same glitch here

src/hotspot/share/gc/shenandoah/shenandoahMarkBitMap.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.

Probably should be 2018, 2019, 2023

src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp line 2:

> 1: /*
> 2:  * Copyright (c) 2015, 2023, Oracle and/or its affiliates. All rights reserved.

same here

src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2015, 2023, Oracle and/or its affiliates. All rights reserved.

check this

-------------

PR: https://git.openjdk.org/jdk/pull/12251