RFR: Combine bitmap clearing with region resetting closure

Y. Srinivas Ramakrishna ysr at openjdk.org
Tue Jan 31 20:29:41 UTC 2023


On Tue, 31 Jan 2023 17:23:48 GMT, William Kemper <wkemper at openjdk.org> wrote:

> This change combines the two closures used to `prepare_gc`. This removes a second iteration over the regions.

Looks good, modulo a comment re `reset_mark_bitmap`.
Reviewed!

src/hotspot/share/gc/shenandoah/shenandoahGeneration.cpp line 213:

> 211: void ShenandoahGeneration::prepare_gc() {
> 212:   // Reset mark bitmap for this generation (typically young)
> 213:   reset_mark_bitmap();

Is `reset_mark_bitmap()` dead code and therefore removable now? Or, can all other usages also be removed in similar manner?

-------------

Marked as reviewed by ysr (Author).

PR: https://git.openjdk.org/shenandoah/pull/208


More information about the shenandoah-dev mailing list