RFR: 8311602 GenShen: Decouple generational mode heuristics [v2]

[William Kemper]

On Mon, 10 Jul 2023 21:12:18 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove overzealous assert
>>  - Fix missing imports (windows build failure)
>
> src/hotspot/share/gc/shenandoah/mode/shenandoahPassiveMode.cpp line 29:
> 
>> 27: #include "gc/shenandoah/heuristics/shenandoahPassiveHeuristics.hpp"
>> 28: #include "gc/shenandoah/mode/shenandoahPassiveMode.hpp"
>> 29: #include "gc/shenandoah/shenandoahGeneration.hpp"
> 
> Are we sure we need this include?  I see no other changes in this source file so it looks suspicious.

We do need that include because `initialize_heuristics` takes a `ShenandoahGeneration*` argument. I added the include here to fix the zero build. I'll modify the interface on the modes to use `ShenandoahHeapCharacteristics` instead. The code for initializing heuristics is a bit over-engineered and I might be able to simplify it further.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/292#discussion_r1259004216