RFR: 8311602 GenShen: Decouple generational mode heuristics [v6]

[William Kemper]

On Thu, 13 Jul 2023 23:19:32 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Record cycle end for old generation heuristic
>
> src/hotspot/share/gc/shenandoah/mode/shenandoahPassiveMode.cpp line 59:
> 
>> 57:   // No barriers are required to run.
>> 58: }
>> 59: ShenandoahHeuristics* ShenandoahPassiveMode::initialize_heuristics(ShenandoahHeapStats* heap_info) const {
> 
> Can take out this argument now.

Can't take it out. It's required by the interface to support initialization of adaptive heuristic.

> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 247:
> 
>> 245:   void decrease_committed(size_t bytes);
>> 246: 
>> 247:   size_t bytes_allocated_since_gc_start();
> 
> Do we really need this?

Yes - this is used by the compact heuristic. Keeping this in minimizes changes to other heuristics.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/292#discussion_r1263146798
PR Review Comment: https://git.openjdk.org/shenandoah/pull/292#discussion_r1263147331