RFR: 8311602 GenShen: Decouple generational mode heuristics [v6]

William Kemper wkemper at openjdk.org
Mon Jul 17 23:26:33 UTC 2023


On Wed, 12 Jul 2023 01:21:16 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Record cycle end for old generation heuristic
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp line 442:
> 
>> 440:         // Signal that promotion failed. Will evacuate this old object somewhere in young gen.
>> 441:         report_promotion_failure(thread, size);
>> 442:         handle_promotion_failure();
> 
> Why is this gone? Is it now handled somewhere else?

The only thing `handle_promotion_failure` did was set a flag on the old heuristic that would cause it to trigger an old collection. That flag is no longer used so I removed all that was setting it.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/292#discussion_r1266000891


More information about the shenandoah-dev mailing list