RFR: 8312321: GenShen: Remembered set scan may encounter garbage objects [v2]

William Kemper wkemper at openjdk.org
Thu Jul 20 15:38:34 UTC 2023


On Thu, 20 Jul 2023 03:01:37 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix trailing whitespace
>>  - Fix typo in comment
>
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 230:
> 
>> 228:     // We chose not to evacuate because we found sufficient immediate garbage. Note that we
>> 229:     // do not check for cancellation here because, at this point, the cycle is effectively
>> 230:     // complete. If the cycle has been cancelled here, the control thread will detect it at
> 
> small typo: extra "at"

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/297#discussion_r1269635176


More information about the shenandoah-dev mailing list