RFR: Incorporate feedback from reviewers

[Y. Srinivas Ramakrishna]

On Thu, 8 Jun 2023 20:49:06 GMT, William Kemper <wkemper at openjdk.org> wrote:

> This PR incorporates changes made in response to https://github.com/openjdk/jdk/pull/14185

LGTM. 🚢

.jcheck/conf line 34:

> 32: pattern=^([124-8][0-9]{6}): (\S.*)$
> 33: 
> 34: [checks "problemlists"]

I'd remove any changes to jcheck by adding it to your gitignore or something.

src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 1278:

> 1276:                                             size_t word_size,
> 1277:                                             size_t* actual_size) {
> 1278:   size_t words_in_card = CardTable::card_size_in_words();

Add a comment such as:


// Align requested sizes to card sized multiples


(Which brings up the question whether the alignment might profitably be made in the caller -- not suggesting this, just wondering; doesn't need to be done here or now.)

-------------

Marked as reviewed by ysr (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/285#pullrequestreview-1470764122
PR Review Comment: https://git.openjdk.org/shenandoah/pull/285#discussion_r1223550082
PR Review Comment: https://git.openjdk.org/shenandoah/pull/285#discussion_r1223554495