RFR: 8310680: GenShen: In-place region promotions may fail [v2]

[William Kemper]

On Fri, 23 Jun 2023 20:32:41 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix formatting
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 1722:
> 
>> 1720:           r->promote_humongous();
>> 1721:         } else if (r->is_regular() && (r->get_top_before_promote() != nullptr)
>> 1722:                   && (r->garbage_before_padded_for_promote() < old_garbage_threshold)
> 
> I think my earlier guidance may have been wrong here.  I think we can rewrite this as:
> else if (r->is_regular() && (r->get_top_before_promote() != nullptr)) {
>   assert(r->garbage_before_padded_for_promote() < old_garbage_threshold, ...)
>   assert (r->get_top_before_promote() == tams, ...)

Okay, will make that change.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/290#discussion_r1240356465