RFR: JDK-8301495: Replace NULL with nullptr in cpu/ppc

Johan Sjölen jsjolen at openjdk.org
Wed Mar 15 13:13:42 UTC 2023


On Tue, 31 Jan 2023 11:39:48 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory cpu/ppc. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
> 
> Thanks!

Found a few minor issues.

src/hotspot/cpu/ppc/frame_ppc.cpp line 114:

> 112: 
> 113:     // At this point, there still is a chance that fp_safe is false.
> 114:     // In particular, (fp == nullptr) might be true. So let's check and

"fp might be null"

src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 1819:

> 1817:   }
> 1818: 
> 1819:   // for (scan = klass->itable(); scan->interface() != null; scan += scan_step) {

nullptr

src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 2710:

> 2708:   // Handle existing monitor.
> 2709:   bind(object_has_monitor);
> 2710:   // The object's monitor m is unlocked iff m->owner == null,

is null

src/hotspot/os/posix/os_posix.cpp line 293:

> 291:         ((MemTracker ::tracking_level() == NMT_detail)
> 292:              ? NativeCallStack(1)
> 293:              : NativeCallStack(NativeCallStack ::FakeMarker ::its_fake)));

Accidentally committed this, will revert to original.

-------------

PR: https://git.openjdk.org/jdk/pull/12323


More information about the shenandoah-dev mailing list