RFR: JDK-8301493: Replace NULL with nullptr in cpu/aarch64

[Stuart Monteith]

On Tue, 31 Jan 2023 11:39:27 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory cpu/aarch64. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
> 
> Thanks!

src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 270:

> 268:   virtual void pass_object() {
> 269:     intptr_t* addr = single_slot_addr();
> 270:     intptr_t value = *addr == 0 ? nullptr : (intptr_t)addr;

This doesn't compile - perhaps replace nullptr with zero? Unless casting it is more appropriate.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12321#discussion_r1143970163