RFR: Restrict generational mode to adaptive heuristic [v3]

William Kemper wkemper at openjdk.org
Wed Mar 29 15:43:25 UTC 2023


> This is a small change to Shenandoah, but it prevents us from running the tests with the generational mode enabled via a jtreg vm option. This requires us to properly integrate the generational mode with the jtreg tests. There are many test files changed, but the `generational` mode is now handled in the same fashion as other modes (`iu`, `passive`). There are two additional advantages to these changes:
> * We no longer need to run the test suite twice (once in the default mode and again with `-XX:ShenandoahGCMode=generational`).
> * Expanded test coverage, as some tests would spawn their own VMs with permutations of mode and heuristic options that ignored the generational mode.

William Kemper has updated the pull request incrementally with two additional commits since the last revision:

 - Use named local variables and add comments to improve readability
 - Revert changes to compiler regression tests

-------------

Changes:
  - all: https://git.openjdk.org/shenandoah/pull/233/files
  - new: https://git.openjdk.org/shenandoah/pull/233/files/28509ca0..12e402ab

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=shenandoah&pr=233&range=02
 - incr: https://webrevs.openjdk.org/?repo=shenandoah&pr=233&range=01-02

  Stats: 279 lines in 22 files changed: 7 ins; 247 del; 25 mod
  Patch: https://git.openjdk.org/shenandoah/pull/233.diff
  Fetch: git fetch https://git.openjdk.org/shenandoah.git pull/233/head:pull/233

PR: https://git.openjdk.org/shenandoah/pull/233


More information about the shenandoah-dev mailing list