RFR: Recompute generation accounts after fullgc
William Kemper
wkemper at openjdk.org
Wed Mar 29 23:08:50 UTC 2023
On Wed, 29 Mar 2023 21:26:40 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
> This fix addresses a problem found during verification following full gcs. This recomputes the generation usage at the end of full GC as part of a 5th phase of full gc.
>
> We may be able to remove this 5th phase at a later time after we find and fix whatever errors exist in generation accounting in the existing full gc implementation.
src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp line 1486:
> 1484: }
> 1485:
> 1486: void ShenandoahFullGC::phase5_restore_generation_accounts() {
Maybe call this `phase5_restore_generation_usage` for consistency with `establish_usage`?
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/235#discussion_r1152574298
More information about the shenandoah-dev
mailing list