RFR: Abandon mixed collections if all candidates are pinned [v2]
William Kemper
wkemper at openjdk.org
Thu Mar 30 16:51:40 UTC 2023
On Wed, 29 Mar 2023 23:44:29 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improve description of new ShenandoahCoalesceChance diagnostic option
>
> src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp line 454:
>
>> 452: "Testing: make lots of artificial allocation failures.") \
>> 453: \
>> 454: product(uintx, ShenandoahCoalesceChance, 0, DIAGNOSTIC, \
>
> Should this read: "Abandon remaining mixed collections with this likelihood. Following each mixed collection, we abandon all remaining mixed collection candidate regions with likelihood ShenandoahCoalesceChance." ? (I don't think this is precisely abandon this percentage of mixed collections".)
Yes, that's a more accurate description. I'll update this description.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/236#discussion_r1153525025
More information about the shenandoah-dev
mailing list