RFR: Enhancements for Shenandoah's generational mode [v6]

[William Kemper]

On Thu, 30 Mar 2023 10:16:53 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with 51 additional commits since the last revision:
>> 
>>  - Fix comment formatting
>>  - Update copyrights
>>  - WIP: Fix issues for live mode
>>  - WIP: Use a fixed size buffer for events
>>  - Show initial logFile argument in toolbar
>>  - Do not load log files on event loop thread
>>  - Factor visualizer frame setup out of main function
>>  - Fix weird 3-space indentation
>>  - Layout improvements
>>  - WIP: Fix warnings
>>  - ... and 41 more: https://git.openjdk.org/shenandoah-visualizer/compare/dadfaff6...06abcd90
>
> src/main/java/org/openjdk/shenandoah/DataConnector.java line 104:
> 
>> 102:                     subscribeToGarbageCollectorNotifications(server);
>> 103:                     monitoredVmConsumer.accept(vm);
>> 104:                     shouldRun = false;
> 
> `shouldRun` looks redundant,  can just `break` out of the `while(true)` loop here.

`shouldRun` can be changed by other threads (for example, when a recording is loaded we stop looking for monitored VMs).

-------------

PR Review Comment: https://git.openjdk.org/shenandoah-visualizer/pull/1#discussion_r1153836251