RFR: Fix satb barrier for object array copy [v2]

Aleksey Shipilev shade at openjdk.org
Fri Mar 31 08:19:08 UTC 2023


On Thu, 30 Mar 2023 23:03:46 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp line 325:
>> 
>>> 323: 
>>> 324:     phase4_compact_objects(worker_slices);
>>> 325: 
>> 
>> This is the part of #235, is it? Should not be in this PR, I think.
>
> I included #235 redundantly here so that I could pass some regression tests.  I've integrated #235 already, so the history shows that commit before this one...

Aha! I think you can merge from master and this would be gone. I am surprised GH does not complain about this, but I guess as long as affected hunks are the same, there is no merge conflict.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/237#discussion_r1154165124


More information about the shenandoah-dev mailing list