RFR: Fix satb barrier for object array copy [v4]

[Kelvin Nilsen]

On Thu, 30 Mar 2023 23:16:12 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refinements requested by reviewers
>
> src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp line 446:
> 
>> 444:    *
>> 445:    * 1. The overwritten array resides in old-gen and it is below TAMS within its old-gen region
>> 446:    * 2. Do not call arraycopy_work for any array residing young-gen because young-gen collection is idle at this time
> 
> ... array residing _in_ young-gen ...

fixed

> src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp line 476:
> 
>> 474:   } else {
>> 475:     T* array = src;
>> 476:     if (!_heap->marking_context()->allocated_after_mark_start(reinterpret_cast<HeapWord*>(array))) {
> 
> Pull `array_addr` up and replace `reinterpret_cast<HeapWord*>(array)` with `array_addr`?

done

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/237#discussion_r1154664724
PR Review Comment: https://git.openjdk.org/shenandoah/pull/237#discussion_r1154664184