RFR: JDK-8305334: GenShen: reference processing needs a card-marking barrier

[Kelvin Nilsen]

On Thu, 30 Mar 2023 22:37:59 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Global collections can create new cross-generational pointers during j.l.r.Reference processing which should be added to the card marking remembered set. The issue was found with dacapo during heap verification and happens somewhat rarely. I added the requisite barrier and have provided a comment describing the sole situation in reference processing that should need the barrier. Assertions check this condition, but the card is also redundantly dirtied for young collections too where it's strictly not needed.
>> 
>> I have tested with and without heap verification using product and fastdebug builds using dacapo and specjbb. Will run it through our internal tests pipeline too before pushing the fix.
>> 
>> I have not yet run any performance comparisons to assess the impact of the checks for applications that traffic heavily in j.l.r.Refs, but am open to any suggestions.
>> 
>> Thank you for your reviews.
>
> src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp line 62:
> 
>> 60: }
>> 61: 
>> 62: template <typename T>
> 
> This looks similar to the code we have for dropping a reference.
> https://github.com/openjdk/shenandoah/blob/2785875de3bf86ab20779c5a24ec7e0f69e452aa/src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp#L397
> 
> Could we use this function there?

Maybe that can be done in a separate PR?  (I'm not sure the commentary of this method is entirely relevant to that other situation.  If it is, feel free to move forward with testing of the change...

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/238#discussion_r1153877827