RFR: Add generations to freeset [v20]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Mon May 1 16:48:31 UTC 2023
On Sat, 29 Apr 2023 13:47:24 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 32:
>>
>>> 30: #include "gc/shenandoah/shenandoahHeap.hpp"
>>> 31:
>>> 32: enum MemoryReserve : uint8_t {
>>
>> Would it tidy up matters to move `ShenandoahSetsOfFree` into its own source file(s)? I realize it's only used by `ShenandoahFreeSet`, but I think it'll keep it all much cleaner.
>
> My preference for expedience is to keep as is. But if you feel strongly, I'll separate it out.
That' fine. Let's leave as is for now, for the reason you state.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/250#discussion_r1181698110
More information about the shenandoah-dev
mailing list