RFR: JDK-8301493: Replace NULL with nullptr in cpu/aarch64 [v3]

[Stuart Monteith]

On Tue, 11 Apr 2023 13:22:40 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory cpu/aarch64. Unfortunately the script that does the change isn't perfect, and so we
>> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
>> 
>> Here are some typical things to look out for:
>> 
>> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
>> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
>> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
>> 
>> An example of this:
>> 
>> ```c++
>> // This function returns null
>> void* ret_null();
>> // This function returns true if *x == nullptr
>> bool is_nullptr(void** x);
>> 
>> 
>> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
>> 
>> Thanks!
>
> Johan Sjölen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Fix style
>  - Merge remote-tracking branch 'origin/master' into JDK-8301493
>  - Explicitly cast
>  - Fixes
>  -  Replace NULL with nullptr in cpu/aarch64

As I'm only an author, I can't sponsor this patch, but it looks OK to me. It is consistent with the NULL->nullptr changes you have been doing elsewhere.

There might always be this problem, but there are some missing instances NULL that may have appeared since you started this - I've listed them below.


codeBuffer_aarch64.cpp:  if (cb->stubs()->maybe_expand_to_ensure_remaining(total_requested_size) && cb->blob() == NULL) {
gc/shared/barrierSetAssembler_aarch64.cpp:  __ cbz(obj, error);      // if klass is NULL it is broken
stubGenerator_aarch64.cpp:    if (bs_nm != NULL) {
vm_version_aarch64.cpp:    if (virt2 != NULL && strcasestr(line, virt2) != 0) {
vm_version_aarch64.cpp:  check_info_file(tname_file, "Xen", XenPVHVM, NULL, NoDetectedVirtualization);

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12321#issuecomment-1531719170