RFR: 8305896: Alternative full GC forwarding [v16]

Roman Kennke rkennke at openjdk.org
Tue May 2 17:37:32 UTC 2023


On Tue, 2 May 2023 17:11:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/slidingForwarding.inline.hpp line 56:
>> 
>>> 54:     // Primary is free
>>> 55:     _bases_table[base_idx] = to_region_base;
>>> 56:   } else if (region_contains(_bases_table[base_idx], to)) {
>> 
>> Stupid question, could this not just be `else if ( _bases_table[base_idx] == to_region_base)` ? Same below?
>
> (kicks himself a little). Yes. Yes, it can. We would not need `region_contains` method then at all, I think.

Indeed! Well spotted!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13582#discussion_r1182827529


More information about the shenandoah-dev mailing list