RFR: 8305896: Alternative full GC forwarding [v32]

Coleen Phillimore coleenp at openjdk.org
Tue May 16 16:57:06 UTC 2023


On Sat, 6 May 2023 22:44:26 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix asserts
>
> src/hotspot/share/gc/shared/slidingForwarding.hpp line 159:
> 
>> 157:  * is sufficient because G1 serial compaction is single-threaded.
>> 158:  */
>> 159: class FallbackTable : public CHeapObj<mtGC>{
> 
> Could this class be placed inside `SlidingForwarding` for better encapsulation?

Why do you write your own hashtable when there's one in utilities/resourceHash.hpp ? there's a put_when_absent() function that is similar than this insert function and faster than put_if_absent().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13582#discussion_r1195447013


More information about the shenandoah-dev mailing list