RFR: Use soft max capacity only for trigger calculations [v2]
William Kemper
wkemper at openjdk.org
Thu May 18 17:18:00 UTC 2023
On Wed, 17 May 2023 20:48:30 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> William Kemper has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Add comment for new method
>> - Re-problem list test with intermittent failures
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 513:
>
>> 511: // for old would be total heap - minimum capacity of young. This means the sum of the maximum
>> 512: // allowed for old and young could exceed the total heap size. It remains the case that the
>> 513: // _actual_ capacity of young + old = total.
>
> Not your change, but it seems like this comment might belong in the _declaration_ of `max_capacity()` (or of `_max_capacity`), rather than here?
I believe this code will also be replaced soon.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/280#discussion_r1198073198
More information about the shenandoah-dev
mailing list