RFR: Changes to simplify MU accounting
Kelvin Nilsen
kdnilsen at openjdk.org
Tue May 23 18:21:36 UTC 2023
On Thu, 11 May 2023 01:05:50 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> This represents a small part of the expand-old-on-demand branch. By itself, this may result in some performance regression because we no longer use MU (mutator utilization) reports to guide generation sizing decisions. On the other hand, the guidance provided by MU metrics does not seem to be a very accurate predictor of ideal generation sizes.
>
> src/hotspot/share/gc/shenandoah/shenandoahMmuTracker.hpp line 78:
>
>> 76: static void fetch_cpu_times(double &gc_time, double &mutator_time);
>> 77:
>> 78: void help_record_concurrent(ShenandoahGeneration* generation, uint gcid, const char* msg);
>
> Do you want to call this `record_concurrent_helper()` or `..._work()` in line with existing helper method convention?
Thanks. Will change this name on expand-old-on-demand branch.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/274#discussion_r1202816311
More information about the shenandoah-dev
mailing list