RFR: Expand old on demand [v42]

[William Kemper]

On Wed, 10 May 2023 23:26:48 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.cpp line 104:
> 
>> 102: 
>> 103: // Returns bytes of old-gen memory consumed by selected aged regions
>> 104: size_t ShenandoahHeuristics::select_aged_regions(size_t old_available, size_t num_regions, bool preselected_regions[]) {
> 
> should probably call this preslected_region_candidates[]

I'd prefer a name that described why these candidates are "pre-selected". Also not clear why these regions aren't added to the collection set through the same process as other regions.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/248#discussion_r1204542743