RFR: Expand old on demand [v42]

Kelvin Nilsen kdnilsen at openjdk.org
Thu May 25 18:29:57 UTC 2023


On Wed, 10 May 2023 23:23:41 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.cpp line 222:
> 
>> 220:   }
>> 221:   heap->set_pad_for_promote_in_place(promote_in_place_pad);
>> 222:   heap->set_promotion_potential(promo_potential);
> 
> An issue: if we're skipping aging cycles, this is overly conservative.

We have changed the accumulation of promo_potential to not include regions that are "tenure_age - 1" if this is not an aging cycle.

> src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp line 1065:
> 
>> 1063:     heap->set_promoted_reserve(promo_reserve);
>> 1064: 
>> 1065:     // TODO: adjust bounds in the free set
> 
> Remove this comment: the bounds are adjusted already.

This comment has been removed.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/248#discussion_r1205874718
PR Review Comment: https://git.openjdk.org/shenandoah/pull/248#discussion_r1205871385


More information about the shenandoah-dev mailing list