RFR: 8319439: Move BufferNode from PtrQueue files to new files

Thomas Schatzl tschatzl at openjdk.org
Tue Nov 7 11:21:27 UTC 2023


On Sat, 4 Nov 2023 11:25:05 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this simple (trivial?) change that moves the BufferNode class
> from share/gc/shared/ptrQueue.[ch]pp to new files
> share/gc/shared/bufferNode.[ch]pp.  The code (as opposed to the surrounding
> boiler plate and #include's) was moved unchanged.
> 
> This led to adding #include's of the new header file to a bunch of other files
> (include what you use), in some cases eliminating the need to #include
> ptrQueue.hpp.  Also tidied up the #include's for ptrQueue.[ch]pp to take
> advantage of the split.
> 
> Also, the gtest gc/shared/test_ptrQueueBufferAllocator.cpp is renamed to  
> gc/shared/test_bufferNodeAllocator.cpp, with some adjustments to includes and
> test naming.
> 
> Testing:
> mach5 tier1

lgtm

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16506#pullrequestreview-1717445517


More information about the shenandoah-dev mailing list