RFR: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading [v2]

Thomas Schatzl tschatzl at openjdk.org
Fri Nov 24 09:18:28 UTC 2023


On Thu, 23 Nov 2023 05:06:53 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   iwalulya review, naming
>
> src/hotspot/share/classfile/classLoaderData.cpp line 602:
> 
>> 600: 
>> 601:   // Clean up class dependencies and tell serviceability tools
>> 602:   // these classes are unloading.  This must be called
> 
> Suggestion:
> 
>   // these classes are unloading. This must be called

Hotspot code style allows comments with both two spaces and one space between sentences in a paragraph. I did not want to change the style there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16759#discussion_r1404116626


More information about the shenandoah-dev mailing list