RFR: JDK-8241503: C2: Share MacroAssembler between mach nodes during code emission [v3]
Cesar Soares Lucas
cslucas at openjdk.org
Wed Nov 29 19:30:24 UTC 2023
> # Description
>
> Please review this PR with a patch to re-use the same C2_MacroAssembler object to emit all instructions in the same compilation unit.
>
> Overall, the change is pretty simple. However, due to the renaming of the variable to access C2_MacroAssembler, from `_masm.` to `masm->`, and also some method prototype changes, the patch became quite large.
>
> # Help Needed for Testing
>
> I don't have access to all platforms necessary to test this. I hope some other folks can help with testing on `S390`, `RISC-V` and `PPC`.
>
> # Testing status
>
> ## tier1
>
> | | Win | Mac | Linux |
> |----------|---------|---------|---------|
> | ARM64 | | | |
> | ARM32 | | | |
> | x86 | | | |
> | x64 | | | |
> | PPC64 | | | |
> | S390x | | | |
> | RiscV | | | |
Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
Some inst_mark fixes; Catch up with master.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/16484/files
- new: https://git.openjdk.org/jdk/pull/16484/files/b56c98de..89a6dff3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=16484&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=16484&range=01-02
Stats: 11 lines in 3 files changed: 7 ins; 4 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/16484.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/16484/head:pull/16484
PR: https://git.openjdk.org/jdk/pull/16484
More information about the shenandoah-dev
mailing list