RFR: 8312117: GenShen: Preempt OLD marking more quickly when YOUNG triggers arise [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Mon Oct 2 19:14:43 UTC 2023
On Mon, 2 Oct 2023 18:05:03 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Have regulator thread wait until expected condition is met
>
> William Kemper has updated the pull request incrementally with two additional commits since the last revision:
>
> - Use same precision for time checks as log messages
> - Regulator lock should protect the write to mode
src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp line 912:
> 910: MonitorLocker ml(&_regulator_lock, Mutex::_no_safepoint_check_flag);
> 911: while (_mode == none) {
> 912: bool timeout = ml.wait(5);
Should this be a globals value? Are there other such "took too long to respond" loops governed by a timeout variable defined in shenandoah_globals.hpp that might be open to overloaded use here perhaps?
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/333#discussion_r1343056111
More information about the shenandoah-dev
mailing list