RFR: 8318053: GenShen: Control thread may ignore requests to start concurrent GC
Y. Srinivas Ramakrishna
ysr at openjdk.org
Thu Oct 12 23:59:08 UTC 2023
On Thu, 12 Oct 2023 23:42:43 GMT, William Kemper <wkemper at openjdk.org> wrote:
> If a request to interrupt an old cycle is accepted, but there is an allocation failure before the requested cycle begins, then the control thread may become stuck in a state where it believes it should ignore further concurrent cycle requests.
Thanks for the extra logging!
Changes look good to me.
Can you add into the ticket the command-line that was used for inducing the errant behavior?
Also can you add into this PR how you tested to confirm that it no longer occurs after the fix?
Thanks!
-------------
Marked as reviewed by ysr (Committer).
PR Review: https://git.openjdk.org/shenandoah/pull/339#pullrequestreview-1675423288
More information about the shenandoah-dev
mailing list