RFR: 8317371: GenShen: Needs improved support for humongous allocation [v3]

Kelvin Nilsen kdnilsen at openjdk.org
Thu Oct 12 23:59:55 UTC 2023


On Thu, 12 Oct 2023 17:37:59 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cosmetic improvements
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 3163:
> 
>> 3161: 
>> 3162:     uint eighths = 8;
>> 3163:     bool triggered = false;
> 
> `triggered` looks unused?

Thanks. Removing.  That was helping me with some diagnostic logging which I removed after debugging was "complete".

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/336#discussion_r1357573037


More information about the shenandoah-dev mailing list