RFR: 8317371: GenShen: Needs improved support for humongous allocation [v3]

[Kelvin Nilsen]

On Thu, 12 Oct 2023 17:48:42 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cosmetic improvements
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 3115:
> 
>> 3113:   size_t young_cset_regions, old_cset_regions;
>> 3114:   size_t first_old_region, last_old_region, old_region_count;
>> 3115:   _free_set->prepare_to_rebuild(young_cset_regions, old_cset_regions, first_old_region, last_old_region, old_region_count);
> 
> Should we have an assert here like:
> ```C++
> assert(first_old_region == _free_set->first_old_region() && last_old_region == _free_set->last_old_region());

Since we don't really need the first_old_region() and last_old_region() methods of ShenandoahFreeSet, they are removed, so we cannot write this assertion.  I'll add a "comparable" assertion to assure sanity.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/336#discussion_r1357587633