RFR: 8317350: Move code cache purging out of CodeCache::UnloadingScope

Tue Oct 17 07:34:22 UTC 2023

On Mon, 16 Oct 2023 14:37:04 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> It is maybe an insignificant detail in the context of stw collectors

Then, could Serial and Parallel use APIs that don't expose these details? For instance, move `flush_unlinked_nmethods` inside `CodeCache::do_unloading`, as it is used only by those collectors.

Why is `flush_unlinked_nmethods` outside of `UnloadingScope`? This newly-introduced scope in the caller context seems extremely out of place, IMO.

> Putting it on this level also allows more straightforward logging.

I don't get this. Can't see any log-print logic inside `flush_unlinked_nmethods`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16011#discussion_r1361632099