RFR: 8317371: GenShen: Needs improved support for humongous allocation [v3]

William Kemper wkemper at openjdk.org
Mon Oct 23 17:18:15 UTC 2023


On Mon, 23 Oct 2023 17:10:17 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Thanks for clarifying.  I kind of like the encapsulating the update as is, because it makes more clear to the code maintainer what these fields represent, and how they got their values.  For performance, I'll add inline to the function definition.  Is that ok?
>
> Okay. Looks like a typo in the log message: `densityr`. A comment describing what `density` is would also be welcome.

Maybe a method `log_fragmentation_trigger_reason`?

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/336#discussion_r1369002496


More information about the shenandoah-dev mailing list