RFR: 8318447: Move NMT source code to own subdirectory
Johan Sjölen
jsjolen at openjdk.org
Wed Oct 25 13:21:40 UTC 2023
On Mon, 23 Oct 2023 08:41:56 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Hi,
>>
>> Thank you for looking through these changes. I applied your comments and also did a run through to look for incorrectly ordered includes. For the gtest source files I separated the includes in a consistent manner, they all look like this pattern now:
>>
>> ```c++
>> #include "precompiled.hpp"
>> #include "memory/allocation.hpp"
>> #include "nmt/mallocHeader.inline.hpp"
>> #include "nmt/memTracker.hpp"
>> #include "runtime/os.hpp"
>>
>> #include "testutils.hpp"
>> #include "unittest.hpp"
>
>> For the gtest source files I separated the includes in a consistent manner, they all look like this pattern now:
>
> That's not what I see in the latest patch. Could you revert that separation and then we can consider that style change in a separate RFE?
@stefank, I believe that I've applied your suggestions, would you mind having another look? Thanks
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16276#issuecomment-1779260132
More information about the shenandoah-dev
mailing list