RFR: 8318057: GenShen: investigate small refactor of remset swap code [v2]

[Kelvin Nilsen]

On Mon, 30 Oct 2023 20:56:59 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Some closures were being unnecessarily applied to free regions rather than just to allocated old and young regions. Restrict the closure application to old and young regions as appropriate, eliminating extra generation affiliation checks in some closures. Also fixed a slightly incorrect documentation comment.
>> 
>> **Update:** I am converting this back to a draft until some further improvements are attempted, and more performance data gathered. Will reopen when done.
>> 
>> **Testing:**
>> 
>> - [x] jtreg and stress tests in test pipeline helper
>> - [x] locally tested with jtreg hotsot_gc tests and with specjbb with and without heap verification
>> - [x] no performance improvements noted; gathering more data, see ticket for latest updates
>
> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - Slight improvement on code in last commit
>  - A paranoid, but useful assert on sizes of types.
>  - Fix Windows build warning.
>  - Fix off by one violating card table API precondition.
>  - Move implementations into .cpp from .hpp.
>    Fix an indexing error.
>  - Merge branch 'master' into swap_rs
>  - Avoid division in card table merge/clear.
>  - Merge branch 'master' into swap_rs
>  - fix for comp error (wrong variable name).
>  -     Avoid including free young regions in young gen heap region
>        iteration.
>  - ... and 1 more: https://git.openjdk.org/shenandoah/compare/b88b8f40...6f241a48

Thanks.

-------------

Marked as reviewed by kdnilsen (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/342#pullrequestreview-1705081554