RFR: 8315044: GenShen: Verifier detects clean card should be dirty [v5]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Sep 5 19:09:14 UTC 2023


On Fri, 1 Sep 2023 21:21:40 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use card_mark_barrier() method and ShenandoahCardBarrier tests
>
> src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp line 590:
> 
>> 588:     if (heap->is_in_old(_pending_list_tail) && heap->is_in_young(former_head_of_global_list)) {
>> 589:       heap->mark_card_as_dirty(_pending_list_tail);
>> 590:     }
> 
> Can we just replace this section with `set_oop_field(_pending_list_tail, former_head_of_global_list)` ?

Have made this improvement, and am retesting.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/314#discussion_r1316289561


More information about the shenandoah-dev mailing list