RFR: JDK-8315479: GenShen: Expand old-gen while selecting collection set during GLOBAL GC [v3]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Sep 6 16:40:08 UTC 2023


On Wed, 6 Sep 2023 15:43:22 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - More typos in comments
>>  - Fix typos in comment
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahGlobalHeuristics.cpp line 146:
> 
>> 144:       }
>> 145:     } else {
>> 146:       assert(r->is_young() && (r->age() < tenuring_threshold), "DeMorgan\'s law");
> 
> Not quite DeMorgan's law because `r` could be unaffiliated (it isn't _supposed_ to be, of course). Does the straight quote needs to be escaped?

I'm fixing the message here.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/318#discussion_r1317550653


More information about the shenandoah-dev mailing list