RFR: 8316755: GenShen: Serviceability needs to know about ShenandoahGenerationalHeap
Aleksey Shipilev
shade at openjdk.org
Mon Sep 25 07:32:01 UTC 2023
On Fri, 22 Sep 2023 20:45:26 GMT, William Kemper <wkemper at openjdk.org> wrote:
> Plumb `ShenandoahGenerationalHeap` into `vmStructs`.
>
> Testing:
>
> make test TEST=hotspot_serviceability TEST_VM_OPTS="-Xlog:gc*=info:file=/tmp/servicability.log -XX:+UseShenandoahGC -XX:+UnlockExperimentalVMOptions -XX:ShenandoahGCMode=generational" CONF=fastdebug
>
> ...
>
> Test results: passed: 319; failed: 0
Good, with minor nit.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shenandoah/ShenandoahGenerationalHeap.java line 33:
> 31: super(addr);
> 32: }
> 33: }
Missing newline here, I think.
-------------
Marked as reviewed by shade (Committer).
PR Review: https://git.openjdk.org/shenandoah/pull/329#pullrequestreview-1641498034
PR Review Comment: https://git.openjdk.org/shenandoah/pull/329#discussion_r1335490484
More information about the shenandoah-dev
mailing list